App Configuration - Query param ordering #44138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrm9084
requested review from
albertofori,
avanigupta,
rossgrambo and
xiangyan99
as code owners
github-actions
bot
added
the
App Configuration
Copilot finished reviewing on behalf of
mrm9084
November 21, 2025 21:21
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds query parameter normalization to the Azure App Configuration SDK to support Azure Front Door as a CDN. The implementation converts query parameter keys to lowercase and sorts them alphabetically to ensure consistent URL formatting across SDK implementations.
Key Changes
- Implemented a new
QueryParamPolicythat normalizes query parameters by lowercasing keys and sorting alphabetically - Integrated the policy into both sync and async clients as part of the request pipeline
- Added comprehensive test coverage with 20+ test cases covering various edge cases including special characters, unicode, empty values, and OData parameters
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
azure/appconfiguration/_query_param_policy.py |
New HTTPPolicy implementation that normalizes query parameters with proper error handling |
tests/test_query_param_policy.py |
Comprehensive test suite covering alphabetical sorting, lowercase conversion, special characters, unicode, empty values, and OData parameters |
azure/appconfiguration/_azure_appconfiguration_client.py |
Integration of QueryParamPolicy into sync client's pipeline |
azure/appconfiguration/aio/_azure_appconfiguration_client_async.py |
Integration of QueryParamPolicy into async client's pipeline |
CHANGELOG.md |
Documentation of the new feature for Azure Front Door support |
assets.json |
Updated test asset tag reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the query parm ordering to be alphabetical, to make sure they are consistent across the sdks. This is needed for Azure Front Door support.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines